Re: [PATCH v9 1/2] mrst: export get_gpio_by_name() function
From: Arjan van de Ven
Date: Sun Mar 27 2011 - 22:47:33 EST
On 3/27/2011 7:47 PM, Feng Tang wrote:
On Mon, 28 Mar 2011 10:34:22 +0800
Arjan van de Ven<arjan@xxxxxxxxxxxxxxx> wrote:
On 3/27/2011 7:29 PM, Lu Guanqun wrote:
Export get_gpio_by_name() function and make its name more focused.
We are doing this because currently get_gpio_by_name() is only used
by the devices exported from SFI DEVS table, but it is also useful
for other PCI devices which also use the GPIO lines, and have their
gpio infos in the SFI GPIO table.
I can't say that I like the new name... at all.
what's "mid" ?
what is wrong with the original name????
Hi Arjan,
The original get_gpio_by_name() is static and only used in mrst.c as it's
mrst/mfld specific. So if we call it from a PCI driver, that name sounds
get_gpio_by_name() would be a very good generic name for a function
provided by the gpio layer as well.
like a platform independent general API while it's actually mrst/mfld bound.
So we would show this dependency from the function name.
that makes no sense.
and again, what on earth is a "mid"??????????
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/