Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig

[OGAWA Hirofumi]

Randy Dunlap <randy.dunlap@xxxxxxxxxx> writes:

>> I don't get this.. you should not be getting CONFIG_NLS=m unless you
>> have stripped you config files really.. :-) Is it possible to get
>> your .config to hit this issue.
>
> I haven't stripped any config files -- but they are randconfig files.
> Two (2) config files that cause build failures are attached.

config PCI_IOAPIC
	bool
	depends on PCI
	depends on ACPI
	depends on HOTPLUG
	default y

select NLS if (DMI || ACPI)

I guess this is simply wrong. It will be parsed as

config PCI_IOAPIC
	bool
	depends on PCI
	depends on ACPI
	depends on HOTPLUG
	default y
	select NLS if (DMI || ACPI)

How about something like the following?

config PCI_LABEL
	bool
        select NLS
        depends on (DMI || ACPI)
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/