Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig

[Randy Dunlap]

On 03/28/11 18:55, OGAWA Hirofumi wrote:
> Randy Dunlap <randy.dunlap@xxxxxxxxxx> writes:
> 
>>> I don't get this.. you should not be getting CONFIG_NLS=m unless you
>>> have stripped you config files really.. :-) Is it possible to get
>>> your .config to hit this issue.
>>
>> I haven't stripped any config files -- but they are randconfig files.
>> Two (2) config files that cause build failures are attached.
> 
> config PCI_IOAPIC
> 	bool
> 	depends on PCI
> 	depends on ACPI
> 	depends on HOTPLUG
> 	default y
> 
> select NLS if (DMI || ACPI)

Ugh.  That looks seriously mucked up.
Dell people, have you checked what it is linux-next for this pci-label stuff?

Jesse, I would drop the b0rked pieces and ask for a new patch.


> I guess this is simply wrong. It will be parsed as
> 
> config PCI_IOAPIC
> 	bool
> 	depends on PCI
> 	depends on ACPI
> 	depends on HOTPLUG
> 	default y
> 	select NLS if (DMI || ACPI)
> 
> How about something like the following?
> 
> config PCI_LABEL
> 	bool
>         select NLS
>         depends on (DMI || ACPI)

What sets/enables it then?
or did you mean:
	def_bool y
and in that case, should it be a user-visible & user-changeable kconfig option?

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/