Re: [GIT PULL] Fix common misspellings

From: Ingo Molnar
Date: Thu Mar 31 2011 - 02:30:17 EST



hi Lucas,

* Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx> wrote:

>
> Hi Linus,
>
> Please pull the following fix for common misspellings in kernel code:
>
> git://git.profusion.mobi/users/lucas/linux-2.6.git for-linus
>
> I was doing it in a per maintainer basis, but as noted by Ingo, this was not
> working out.
>
> There's only one big patch that fixes misspellings in
> * Documentation
> * Comments
> * Strings that are used only in printk and the like

I've gone over your changes and noticed one very small thing, you've changed
copyright strings as well:

- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007-2008 Marvell Internation Ltd.
+ * Copyright (C) 2007-2008 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (c) 2002 The Regents of the Unviersity of Michigan
+ * Copyright (c) 2002 The Regents of the University of Michigan

While all the fixes are correct, i'd advise against changing copyright notices
without the SOB of the authors. The s/Unviersity/University fix would be ok i
guess because it's a very clear typo, but the Marvell one is borderline (while
it too is probably a typo) i think it needs a signoff from those who put the
copyright notices there in that form.

You could leave out those bits from the patch as well.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/