Re: [GIT PULL] Fix common misspellings
From: Lucas De Marchi
Date: Thu Mar 31 2011 - 09:53:12 EST
Hi Ingo,
On Thu, Mar 31, 2011 at 3:29 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> I've gone over your changes and noticed one very small thing, you've changed
> copyright strings as well:
>
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007-2008 Marvell Internation Ltd.
> + * Copyright (C) 2007-2008 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (c) 2002 The Regents of the Unviersity of Michigan
> + * Copyright (c) 2002 The Regents of the University of Michigan
>
> While all the fixes are correct, i'd advise against changing copyright notices
> without the SOB of the authors. The s/Unviersity/University fix would be ok i
> guess because it's a very clear typo, but the Marvell one is borderline (while
> it too is probably a typo) i think it needs a signoff from those who put the
> copyright notices there in that form.
>
> You could leave out those bits from the patch as well.
Ok. I saw these when manually reviewing and a 'git grep "Marvell
International Ltd"' revealed a lot of places using "the right form",
so I assumed they were in fact typos.
I'll remove them for now, and send a separate patch later asking for
the required s-o-b.
thanks
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/