Re: [RFC][PATCH] axi: add AXI bus driver

[Arend van Spriel]

On Tue, 12 Apr 2011 22:44:01 +0200, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:

> 2011/4/12 George Kashperko <george@xxxxxxxxxxx>:
> > > 2011/4/12 RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
> > > That way I see really low (or not at all) relation between out
> > > (not)Broadcom bus and present AMBA bus.
> > Agree.
>
> Ehh, sounds like one more renaming to functions, defines, prefixes.
>
> Let's wait for Arend comments, he was the one voting for  
> not-bcm-specific name.

Hi RafaÅ,

Still think its better to stick with a generic name even if currently you  
only come across this in Broadcom chips right now. I do agree that the  
term 'axi' is implying something else than what this bus driver is  
providing. The name 'axi-dmp' I gave earlier may be more to the point.

I also looked at the amba driver after receiving comments on the brcmaxi  
library module (this is what Hauke Mehrtens referred to) and came to  
similar conclusion as you did. It does however support PM properly so you  
may want to get inspiration in that area. I also noticed a reference to  
AMBA term APB which is a different bus in the AMBA family. AXI was  
introduced later as higher performance bus (in AMBA rev3 if I remember  
correctly).

Gr. AvS
--
"The world is indeed comic, but the joke is on mankind." â H.P. Lovecraft

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/