Re: [PATCH v3] x86, vt-d: enable x2apic opt out

[Valdis . Kletnieks]

On Tue, 24 May 2011 11:36:14 EDT, Youquan Song said:
> > If we're doing a WARN level here, what are the downsides of just automagically
> > forcing it rather than making them use a kernel parameter and reboot?  
> 
> As we have discussed before, x2apci opt out feature is requested from OEM that
> they want to firmware tell OS to opt out x2apic when the platform,
> hardware or BIOS is not ready to support x2apic. So we can not reboot or
> force to use kernel parameter.  

Do we want an actual WARN there, complete with stack traceback and all?

Or did you intend a pr_warn or printk(KERN_WARNING or similar?

Attachment: pgp00000.pgp
Description: PGP signature