Re: [PATCH] Avoid Wunused-but-set warning
From: Pekka Enberg
Date: Sun Jul 10 2011 - 13:24:32 EST
Hi Arnaud!
On Sun, Jul 10, 2011 at 7:49 PM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
>> What kind of status do you need to ACK such a simple patch?
>>
> As per Documentation/SubmittingPatches:
[snip]
> That said, it is not a strong requirement... unfortunately. So, let's
> have some fun and go ACK thousand of trivial patch just to generate
> traffic on the LKML and give myself self-importance :-)
Hey, thank you so much for quoting Documentation/SubmittingPatches for me!
I've read it a long time ago but I now see I've completely
misunderstood how things work around here. How silly of me to assume
patches posted on LKML were fair game for anyone to review and that it
was appreciated given that there's chronic lack of reviewers for
pretty much everything. Thank you for setting me straight on the
subject!
I see you've been rather busy with important Kconfg work recently but
I can only hope you'll find the time to enforce "Acked-by" status on
LKML in the future as well!
P.S. There are other tags such as Tested-by and Reviewed-by which you
might also want to police a bit as well - I hear people without proper
testing or reviewing status are doing those things all the time!
Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/