Re: [PATCH v3] fs, dlm: don't do pointless NULL check, use kzallocand fix order of arguments

[David Teigland]

On Sun, Jul 10, 2011 at 10:54:31PM +0200, Jesper Juhl wrote:
> In fs/dlm/lock.c in the dlm_scan_waiters() function there are 3 small
> issues:
> 
> 1) There's no need to test the return value of the allocation and do a
> memset if is succeedes. Just use kzalloc() to obtain zeroed memory.
> 
> 2) Since kfree() handles NULL pointers gracefully, the test of
> 'warned' against NULL before the kfree() after the loop is completely
> pointless. Remove it.
> 
> 3) The arguments to kmalloc() (now kzalloc()) were swapped. Thanks to
> Dr. David Alan Gilbert for pointing this out.
> 
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Thanks, I pushed this and a patch for the other swapped kmalloc to the
next branch.
Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/