Re: [PATCH 2/2] x86: Enable monitor/mwait on Intel if BIOS hasn'talready

[Matthew Garrett]

On Wed, Aug 03, 2011 at 03:17:59PM -0400, Len Brown wrote:
> > >> What machine has this BIOS bug, and are you running
> > >> the latest version of the BIOS?
> > >
> > > Intel DQ67SW, version SWQ6710H.86A.0051.2011.0413.1154.  This is not
> > > quite up-to-date -- I'll test a newer BIOS.
> > 
> > SWQ6710H.86A.0053.2011.0615.1535 has the same problem.  It fixed ASPM, though :)
> > 
> > Should I redo the patch with a printk to warn about the firmware bug?
> 
> I would hope that a patch that _only_ prints [Firmware bug]
> should be enough.  This isn't the kind of workaround
> that we should really have to carry in the kernel.

We can't trust BIOS authors to get things right. Where we can reliably 
fix up things that are broken, we should do so.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/