Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSDInitiator library

[Maxin B John]

Ping..

On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@xxxxxxxxx> wrote:
> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
> in Kconfig so that the requirements are met automatically.
>
> Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx>
> ---
> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
> index 861b5ce..1535fe1 100644
> --- a/drivers/scsi/osd/Kconfig
> +++ b/drivers/scsi/osd/Kconfig
> @@ -11,17 +11,16 @@
>  # it under the terms of the GNU General Public version 2 License as
>  # published by the Free Software Foundation
>  #
> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
> -#        How is it done properly?
>  #
>
>  config SCSI_OSD_INITIATOR
>        tristate "OSD-Initiator library"
>        depends on SCSI
> +       select CRYPTO
> +       select CRYPTO_SHA1
> +       select CRYPTO_HMAC
>        help
>                Enable the OSD-Initiator library (libosd.ko).
> -               NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
> -               dependencies
>
>  config SCSI_OSD_ULD
>        tristate "OSD Upper Level driver"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/