Re: linux-next: build failure after merge of the final tree(staging tree related)

From: Stephen Rothwell
Date: Wed Aug 24 2011 - 18:54:40 EST


Hi Greg,

On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@xxxxxxxxx> wrote:
>
> To fix it, all we have to do is include linux/vmalloc.h, right? Or is

I would assume so.

> ppc "special" in some other way regarding this call?

I assume it happens just because vmalloc.h is implicitly included by some
other header file on x86 and not on ppc.

This is why we have "Rule 1" in Documentation/SubmitChecklist. Relying
on the implicit inclusion of header files is bound to trip us up on some
architecture or platform or combination of CONFIG options.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature