Re: linux-next: build failure after merge of the final tree (stagingtree related)

From: Greg KH
Date: Wed Aug 24 2011 - 18:58:11 EST


On Thu, Aug 25, 2011 at 08:54:20AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@xxxxxxxxx> wrote:
> >
> > To fix it, all we have to do is include linux/vmalloc.h, right? Or is
>
> I would assume so.
>
> > ppc "special" in some other way regarding this call?
>
> I assume it happens just because vmalloc.h is implicitly included by some
> other header file on x86 and not on ppc.
>
> This is why we have "Rule 1" in Documentation/SubmitChecklist. Relying
> on the implicit inclusion of header files is bound to trip us up on some
> architecture or platform or combination of CONFIG options.

Fair enough, I've made this fix in my tree, so it should be good now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/