Re: [PATCH] driver/misc/fsa9480.c fix potential null-pointerdereference

[Andrew Morton]

On Tue, 26 Jul 2011 17:19:35 +0900
jhbird.choi@xxxxxxxxxxx wrote:

> From: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
>  drivers/misc/fsa9480.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c
> index 5325a7e..0bd1e5b 100644
> --- a/drivers/misc/fsa9480.c
> +++ b/drivers/misc/fsa9480.c
> @@ -400,7 +400,8 @@ static int fsa9480_irq_init(struct fsa9480_usbsw *usbsw)
>  			return ret;
>  		}
>  
> -		device_init_wakeup(&client->dev, pdata->wakeup);
> +		if (pdata)
> +			device_init_wakeup(&client->dev, pdata->wakeup);
>  	}
>  
>  	return 0;

So i2c_client.dev.platform_data was NULL.  Is this an allowed state? 
What would cause this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/