Re: [RFC][PATCH 3/3] ASoC: wm8940: Do not left shift the divparameter in wm8940_set_dai_clkdiv
From: Mark Brown
Date: Mon Oct 24 2011 - 06:10:26 EST
On Mon, Oct 24, 2011 at 11:35:12AM +0800, Axel Lin wrote:
> Just check with other codec drivers, we do left shit div for
> the corresponding bits from the caller in all other drivers.
> I don't find the caller calling wm8940_set_dai_clkdiv now,
> just make the behavior consistent with other drivers.
The semantics for the clkdivs are entirely defined by the individual
drivers - there's no actual standard here and I guess this may break
some out of tree machines that people have. If we're going to a cleanup
here it'd be better to improve the driver to figure out the divider
configurations automatically as far as possible.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/