Re: [PATCHv5 16/19] power_supply: Convert all users to new usb_phy

[Heikki Krogerus]

Hi,

On Mon, Oct 10, 2011 at 11:08:12PM +0400, Anton Vorontsov wrote:
> On Mon, Oct 03, 2011 at 04:10:55PM +0300, Heikki Krogerus wrote:
> [...]
> > > +static inline int
> > > +isp1704_read(struct isp1704_charger *isp, u32 reg)
> 
> Cosmetic nitpick: I don't see any reason to break this into two lines.
> 
> > > +{
> > > +	return usb_phy_io_read(isp->xceiv, reg);
> > > +}
> > > +
> > > +static inline int
> > > +isp1704_write(struct isp1704_charger *isp, u32 val, u32 reg)
> 
> Same here.
> 
> I assume you want this patch to go via some other tree, so feel
> free to add
> 
> Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> 
> Thanks!

Thanks Anton. I'll change them.

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/