Re: [PATCH 1/4] PM / Sleep: Make pm_op() and pm_noirq_op() returncallback pointers

[Namhyung Kim]

2011-12-13 (í), 00:53 +0100, Rafael J. Wysocki:
> On Monday, December 12, 2011, Namhyung Kim wrote:
> > Rafael J. Wysocki <rjw <at> sisk.pl> writes:
> > 
> > > 
> > > From: Rafael J. Wysocki <rjw <at> sisk.pl>
> > > 
> > > Make the pm_op() and pm_noirq_op() functions return pointers to
> > > appropriate callbacks instead of executing those callbacks and
> > > returning their results.
> > > 
> > > This change is required for a subsequent modification that will
> > > execute the corresponding driver callback if the subsystem
> > > callback returned by either pm_op(), or pm_noirq_op() is NULL.
> > > 
> > 
> > Hello Rafael,
> > 
> > How about typedef'ing something like pm_callback_t for readability?
> > 
> >    typedef int (*pm_callback_t)(struct device *);
> > 
> > This way, the code will be easier to read.
> 
> Do you mean something like in the patch below?  It does look a bit simpler.
> 

Yes, indeed. The patch looks better to me. :)

Thanks,
Namhyung Kim



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/