Re: [PATCH 1/2] pinctrl: correct a offset while enumerating pins

[Linus Walleij]

On Tue, Jan 3, 2012 at 9:37 AM, Chanho Park <chanho61.park@xxxxxxxxxxx> wrote:
>> From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
>> On Tue, Jan 3, 2012 at 8:47 AM, Chanho Park <chanho61.park@xxxxxxxxxxx>
>> This:
>>
>> > -               /* Pin space may be sparse */
>> > +               /* Skip if we cannot search the pin */
>> (...)
>> > -               /* Pin space may be sparse */
>> > +               /* Skip if we cannot search the pin */
>>
>> I don't see why you're changing that comment, it is still true that
>> the pin space may be sparse and that is what your patch confirms.
>>
>> So I will restore that comment...
>
> We do not concern that pin space is sparse
> because we enumerate the pin space using the offset of array.
> This situation is that we cannot search the pin from radix tree.
> It is BUGON() or just skip this pin :)

Yes but the comment there is about why we are searching
the radix tree instead of just inserting the new pin. If the
radix tree was not sparse, we would not need to search
it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/