Re: [PATCH] mce: fix warning messages about static struct mce_device
From: Ingo Molnar
Date: Tue Jan 17 2012 - 03:39:21 EST
* Greg KH <gregkh@xxxxxxx> wrote:
> diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
> index f35ce43..6aefb14 100644
> --- a/arch/x86/include/asm/mce.h
> +++ b/arch/x86/include/asm/mce.h
> @@ -151,7 +151,7 @@ static inline void enable_p5_mce(void) {}
>
> void mce_setup(struct mce *m);
> void mce_log(struct mce *m);
> -DECLARE_PER_CPU(struct device, mce_device);
> +extern struct device *mce_device[CONFIG_NR_CPUS];
Minor nit, i don't think we have any other such [CONFIG_NR_CPUS]
pattern in the kernel.
This should be something like:
DECLARE_PER_CPU(struct device *, mce_device);
Or the pointer should be attached to the CPU info structure.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/