RE: [PATCH 1/1] Input: tegra-kbc - remove pre Tegra20 definitions
From: Stephen Warren
Date: Wed Jan 18 2012 - 11:36:27 EST
Dmitry Torokhov wrote at Tuesday, January 17, 2012 5:30 PM:
> On Tue, Jan 17, 2012 at 03:26:50PM -0800, Rakesh Iyer wrote:
> > Add support for Tegra30 by correcting definitions. This is necessary to
> > make driver useful in Tegra30.
>
> So what about older versions? There still could be users...
I wonder if there will be problems with this patch; the loop in
tegra_kbc_report_keys() is going to process 8 bits more of the last
register and the loop in tegra_kbc_config_pins() will now touch one
more row and one more column register. I think these loops should be
limited at run-time based on the SoC actually being executed upon?
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/