RE: [PATCH 1/1] Input: tegra-kbc - remove pre Tegra20 definitions

[Stephen Warren]

Stephen Warren wrote at Wednesday, January 18, 2012 9:36 AM:
> Dmitry Torokhov wrote at Tuesday, January 17, 2012 5:30 PM:
> > On Tue, Jan 17, 2012 at 03:26:50PM -0800, Rakesh Iyer wrote:
> > > Add support for Tegra30 by correcting definitions. This is necessary to
> > > make driver useful in Tegra30.
> >
> > So what about older versions? There still could be users...
> 
> I wonder if there will be problems with this patch; the loop in
> tegra_kbc_report_keys() is going to process 8 bits more of the last
> register and the loop in tegra_kbc_config_pins() will now touch one
> more row and one more column register. I think these loops should be
> limited at run-time based on the SoC actually being executed upon?

Sorry, I read the ifdef the wrong way around. The new values are for
Tegra20 and should have been in use all along. There are no old
versions to consider here, since chips before Tegra20 aren't supported
by mainline (or any??) Linux.

So,

Acked-by: Stephen Warren: <swarren@xxxxxxxxxx>

Sorry for the confusion.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/