Re: [PATCH 2/2] ARM: dma-mapping: fix leak in consistent_init

[Ajeet Yadav]

thank you for kind review, but how can I resent the patch using same mail chain

git send-email --smtp-encryption=tls --smtp-server=smtp.gmail.com
--smtp-user=ajeet.yadav.77@xxxxxxxxx --smtp-server-port=587 --from
"Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>" --to "Russell King
<linux@xxxxxxxxxxxxxxxx>" --to "Jon Medhurst <tixy@xxxxxxxxxx>" --to
"Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>" --to "Catalin Marinas
<catalin.marinas@xxxxxxx>" --to "Sumit Bhattacharya
<sumitb@xxxxxxxxxx>" --to "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" --to
"linux-kernel@xxxxxxxxxxxxxxx"
0002-ARM-dma-mapping-fix-leak-in-consistent_init.patch

On Fri, Feb 17, 2012 at 6:42 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Fri, Feb 17, 2012 at 06:39:55PM +0530, Ajeet Yadav wrote:
>> Although the error in this case is unlikely, but logically
>> if error occurs then we leak memory.
>>
>> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
>> ---
>> Âarch/arm/mm/dma-mapping.c | Â 24 ++++++++++++------------
>> Â1 files changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> index 04bfa76..b8cf062 100644
>> --- a/arch/arm/mm/dma-mapping.c
>> +++ b/arch/arm/mm/dma-mapping.c
>> @@ -161,7 +161,6 @@ static struct arm_vmregion_head consistent_head = {
>> Â */
>> Âstatic int __init consistent_init(void)
>> Â{
>> - Â Â int ret = 0;
>> Â Â Â pgd_t *pgd;
>> Â Â Â pud_t *pud;
>> Â Â Â pmd_t *pmd;
>> @@ -171,7 +170,7 @@ static int __init consistent_init(void)
>> Â Â Â unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>>
>> Â Â Â consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
>> - Â Â if (!consistent_pte) {
>> + Â Â if (unlikely(!consistent_pte)) {
>
> Please get rid of these unlikelys. ÂThis really isn't a performance
> critical path.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/