Re: [PATCH] trace: don't print an extra separator of flags

[avagin@xxxxxxxxx]

On 02/20/2012 10:09 PM, Steven Rostedt wrote:
> On Sun, 2012-02-19 at 14:16 +0300, Andrew Vagin wrote:
> > From: Andrey Vagin<avagin@xxxxxxxxxx>
> >
> > It occurs if __print_flags is used more than once
>
> Hi, which tracepoint does this? I like to see what the issue is.

The mainstream kernel doesn't have such trace-point, but I have.

Do you want to say that this bug should not be fixed in this case? :)

> Thanks,
>
> -- Steve
>
> > Signed-off-by: Andrew Vagin<avagin@xxxxxxxxxx>
> > ---
> >   kernel/trace/trace_output.c |    6 ++++--
> >   1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> > index 0d6ff35..3efd718 100644
> > --- a/kernel/trace/trace_output.c
> > +++ b/kernel/trace/trace_output.c
> > @@ -300,7 +300,7 @@ ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
> >   	unsigned long mask;
> >   	const char *str;
> >   	const char *ret = p->buffer + p->len;
> > -	int i;
> > +	int i, first = 1;
> >
> >   	for (i = 0;  flag_array[i].name&&  flags; i++) {
> >
> > @@ -310,8 +310,10 @@ ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
> >
> >   		str = flag_array[i].name;
> >   		flags&= ~mask;
> > -		if (p->len&&  delim)
> > +		if (!first&&  delim)
> >   			trace_seq_puts(p, delim);
> > +		else
> > +			first = 0;
> >   		trace_seq_puts(p, str);
> >   	}
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/