Re: [PATCH v3] regulator: Add TPS65090 regulator driver

[Mark Brown]

On Thu, Mar 22, 2012 at 06:34:09PM +0530, Venu Byravarasu wrote:
> Add TPS65090 regulator driver
> 
> TPS65090 PMIC from TI consists of 3 step down converters,
> 2 always on LDOs and 7 current limited load switches. The
> output voltages are ON/OFF controllable and are meant to
> supply power to the components on target board.

Applied, but...

> +	rdev = regulator_register(&ri->desc, &pdev->dev,
> +				&tps_pdata->regulator, ri, NULL);
> +	if (IS_ERR_OR_NULL(rdev)) {

...please submit an incremental patch changing this to plain IS_ERR(),
regulator_register() only returns error pointers.  Note that no other
regulator drivers do this check.

Attachment: signature.asc
Description: Digital signature