Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support massof disks naming

From: James Bottomley
Date: Mon Apr 02 2012 - 14:56:16 EST


On Mon, 2012-04-02 at 11:52 -0700, Tejun Heo wrote:
> > Probably same. Renaming existing devices will break setups.
> > I think the idea is to avoid using the
> > legacy naming in new drivers *that will be added from now on*.
>
> Yeap.

So if we're agreed no other devices going forwards should ever use this
interface, is there any point unifying the interface? No matter how
many caveats you hedge it round with, putting the API in a central place
will be a bit like a honey trap for careless bears. It might be safer
just to leave it buried in the three current drivers.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/