Re: [RFC v2 2/5] PM, Add sysfs file power_off to control device poweroff policy

[huang ying]

On Sat, May 5, 2012 at 3:50 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Fri, May 4, 2012 at 2:13 AM, Huang Ying <ying.huang@xxxxxxxxx> wrote:
>> From: Lan Tianyu <tianyu.lan@xxxxxxxxx>
>>
>> Some devices can be powered off to save more power via some platform
>> mechanism, e.g., ACPI. ÂBut that may not work as expected for some
>> device or platform. ÂSo, this patch adds a sysfs file named power_off
>> under <device>/power directory to provide a mechanism for user to control
>> whether to allow the device to be power off.
>>
>> power_off => "enabled" means allowing the device to be powered off if
>> possible.
>>
>> power_off => "disabled" means the device must be power on anytime.
>>
>> Also add flag power_off_user to struct dev_pm_info to record users'
>> choice. The bus layer can use this field to determine whether to
>> power off the device.
>
> My first thought was that writing to "power_off" would actually turn
> the power off, which isn't true. ÂMaybe something like
> "poweroff_allowed" would work.

Yes. "power_off" is not a good name.  "poweroff_allowed" is much better.

> I think there's only one use of this new field, in
> pci_pm_runtime_suspend(). ÂMaybe you could pull out that hunk from
> patch 5, combine it with this one, and move it to after patch 5?

This will be used by various places, such as ZPODD support, power domain, etc.

Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/