Re: [RFC v2 3/5] PCIe, Add runtime PM support to PCIe port

[huang ying]

On Sat, May 5, 2012 at 3:43 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Friday, May 04, 2012, Huang Ying wrote:
>> From: Zheng Yan <zheng.z.yan@xxxxxxxxx>
>>
>> This patch adds runtime PM support to PCIe port. ÂThis is needed by
>> PCIe D3cold support, where PCIe device in slot may be powered on/off
>> by PCIe port.
>>
>> Because runtime suspend is broken for some chipset, a white list is
>> used to enable runtime PM support for only chipset known to work.
>>
>> Signed-off-by: Zheng Yan <zheng.z.yan@xxxxxxxxx>
>> Signed-off-by: Huang Ying <ying.huang@xxxxxxxxx>
>> ---
>> Âdrivers/pci/pci.c       Â|  Â9 +++++++++
>> Âdrivers/pci/pcie/portdrv_pci.c | Â 40 ++++++++++++++++++++++++++++++++++++++++
>> Â2 files changed, 49 insertions(+)
>>
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -1476,6 +1476,15 @@ bool pci_check_pme_status(struct pci_dev
>> Â */
>> Âstatic int pci_pme_wakeup(struct pci_dev *dev, void *pme_poll_reset)
>> Â{
>> + Â Â struct pci_dev *bridge = dev->bus->self;
>> +
>> + Â Â /*
>> + Â Â Â* If bridge is in low power state, the configuration space of
>> + Â Â Â* subordinate devices may be not accessible
>
> Please also say in the comment _when_ this is possible. ÂThat's far from
> obvious, because the runtime PM framework generally ensures that parents are
> resumed before the children, so the comment should describe the particular
> scenario leading to this situation.

OK.  I will add something like below into comments.

This is possible when doing PME poll.

>> + Â Â Â*/
>> + Â Â if (bridge && bridge->current_state != PCI_D0)
>> + Â Â Â Â Â Â return 0;
>> +
>> Â Â Â if (pme_poll_reset && dev->pme_poll)
>> Â Â Â Â Â Â Â dev->pme_poll = false;
>>
>> --- a/drivers/pci/pcie/portdrv_pci.c
>> +++ b/drivers/pci/pcie/portdrv_pci.c
>> @@ -11,6 +11,7 @@
>> Â#include <linux/kernel.h>
>> Â#include <linux/errno.h>
>> Â#include <linux/pm.h>
>> +#include <linux/pm_runtime.h>
>> Â#include <linux/init.h>
>> Â#include <linux/pcieport_if.h>
>> Â#include <linux/aer.h>
>> @@ -99,6 +100,27 @@ static int pcie_port_resume_noirq(struct
>> Â Â Â return 0;
>> Â}
>>
>> +#ifdef CONFIG_PM_RUNTIME
>> +static int pcie_port_runtime_suspend(struct device *dev)
>> +{
>> + Â Â struct pci_dev *pdev = to_pci_dev(dev);
>> +
>
> A comment explaining why this is needed here would be welcome.

Sorry, do not catch your idea exactly.  What is needed?  Why do we
need to add PCIe port runtime suspend support?

Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/