Re: [PATCH 00/15] tools: Unify perf and trace-cmd trace event format parsing v3

[Namhyung Kim]

Hi,

On Mon, 7 May 2012 10:14:24 +0200, Ingo Molnar wrote:
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
>
>> Hi,
>> 
>> This is essentially a rebase against latest tip:perf/core updates.
>> Mostly due to conflicts against the perf Makefile updates.
>> 
>> I think we all agree that this library needs improvements but these
>> should rather be done incrementally. The current perf trace event parsing
>> is anyway much backward compared to that library.
>> 
>> Default target is a static library in tools/libtraceevent/libtraceevent.a
>> 
>> This can be pulled from:
>> 
>> git://github.com/fweisbec/tracing.git
>> 	perf/parse-events-4
>
> It gives me:
>
> /home/mingo/tip/tools/lib/traceevent/parse-filter.c: In function âcreate_arg_itemâ:
> /home/mingo/tip/tools/lib/traceevent/parse-filter.c:343:9: warning: comparison between âenum filter_arg_typeâ and âenum event_typeâ [-Wenum-compare]
> /home/mingo/tip/tools/lib/traceevent/parse-filter.c:339:2: warning: case value â8â not in enumerated type âenum filter_arg_typeâ [-Wswitch]
>
> Had this been in tools/perf/ it would use -Werror already and 
> you'd have fixed it, not requiring me to unpull these bits :-/
>

I already submitted a patch for it (along with other fixes) to Steven.

  lkml.indiana.edu/hypermail/linux/kernel/1204.2/03713.html


Thanks,
Namhyung


> So can we please make a libevent.so, built sanely within 
> tools/perf/lib/ or such and distributed together with perf so 
> that the two can never get out of sync?
>
> Thanks,
>
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/