Re: [PATCH 1/3] uprobes: install_breakpoint() should fail ifis_swbp_insn() == T

[Oleg Nesterov]

On 05/31, Oleg Nesterov wrote:
>
> __find_next_vma_info() checks tmpvi->mm == vma->vm_mm to detect the
> already visited mm/vma. However, afaics this can be false positive?

Yes, but I guess this is harmless, we can rely on uprobe_mmap.



But. Doesn't this mean we can greatly simplify register_for_each_vma()
and make it O(n) ?

Unless I missed something, we can simply create the list of
mm/vaddr structures under ->i_mmap_mutex (vma_prio_tree_foreach), then
register_for_each_vma() can process the list and that is all.

If another mapping comes after we drop i_mmap_mutex, uprobe_mmap()
should be called and it should install the bp.


Srikar, Peter, what do you think?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/