Re: [patch 12/12] mm: correctly synchronize rss-counters at exit/exec

[Linus Torvalds]

Ugh, looking more at the patch, I'm getting more and more convinces
that it is pure and utter garbage.

It does "sync_mm_rss(mm);" in mmput(), _after_ it has done the
possibly final mmdrop(). WTF?

This is crap, guys. Seriously. Stop playing russian rulette with this
code. I think we need to revert *all* of the crazy rss games, unless
Konstantin can show us some truly obviously correct fix.

Sadly, I merged and pushed out the crap before I had rebooted and
noticed this problem, so now it's in the wild. Can somebody please
take a look at this asap?

             Linus

On Thu, Jun 7, 2012 at 5:17 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> This patch actually seems to have made the
>
>  BUG: Bad rss-counter state ..
>
> problem *much* worse. It triggers all the time for me now - I've got
> 408 of those messages on my macbook air within a minute of booting it.
>
> Not good. Especially not good when it's marked for stable too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/