Re: [PATCH 4/5] gpio: tps6586x: add gpio support through platformdriver

[Laxman Dewangan]

On Sunday 15 July 2012 03:48 AM, Linus Walleij wrote:
> On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan<ldewangan@xxxxxxxxxx>  wrote:
>
> > Converting the gpio driver of tps6586x to a platform
> > driver in place of registering the gpio through core
> > driver.
> > The motivation of the change is:
> > - This is inline with the mfd drivers implementation.
> > - This will move the related gpio support to gpio driver
> >    folder where all gpio related drivers are available.
> >    This will be easy the maintenance and enhancement is
> >    anything done for gpio.
> > - The gpio functionality can be selected through config
> >    variable.
> >
> > Signed-off-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>
> Overall this is very, very good and you're doing the right thing.
>
> > --- /dev/null
> > +++ b/drivers/gpio/gpio-tps6586x.c
> > +#include<linux/i2c.h>
> Why?

Removed this inclusion as it is not require.

> Reviewed-by: Linus Walleij<linus.walleij@xxxxxxxxxx>

I will add your reviewed-by in my next patch for easyness.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/