Re: [PATCH 5/5] mfd: tps6586x: remove gpio support from core driver

From: Laxman Dewangan
Date: Mon Jul 16 2012 - 02:57:52 EST


On Sunday 15 July 2012 03:42 AM, Linus Walleij wrote:
On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan<ldewangan@xxxxxxxxxx> wrote:

The GPIO functionality of device tps6586x is added through
platform gpio driver and it can be register as the mfd sub
device and hence removing the duplicates code which register
the gpio functionality from core driver.

Signed-off-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>
The only thing I worry about is if old defconfig files are now
missing this config option and then this patch becomes an
unbisectable showstopper for them because they don't get
this driver by default anymore.

So please make sure you've grepped around and checked
that of some platforms defconfig was previously selecting
the core driver, make sure it selects this driver too for
the moment, it's better if they later deactivate it
if they don't need it.

Grep shows that only arm based platform tegra_defconfig is using this device.
I have added the change in tegra_defconfig and will send as part of this series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/