Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

[Ryan Mallon]

On 04/09/12 00:14, yan wrote:
> Signed-off-by: yan <clouds.yan@xxxxxxxxx>
> ---
>  fs/proc/generic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/proc/generic.c b/fs/proc/generic.c
> index b3647fe..9e8f631 100644
> --- a/fs/proc/generic.c
> +++ b/fs/proc/generic.c
> @@ -427,7 +427,7 @@ struct dentry *proc_lookup_de(struct proc_dir_entry *de, struct inode *dir,
>  		if (!memcmp(dentry->d_name.name, de->name, de->namelen)) {
>  			pde_get(de);
>  			spin_unlock(&proc_subdir_lock);
> -			error = -EINVAL;
> +			error = -ENOMEM;

This seems incorrect. This function doesn't allocate anything, it looks
up an inode. From my reading it looks like -EINVAL is returned here if
the dentry name matches, but the inode cannot be found.

~Ryan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/