Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

From: Cong Wang
Date: Mon Sep 03 2012 - 23:02:04 EST


On 09/03/2012 10:14 PM, yan wrote:
Signed-off-by: yan <clouds.yan@xxxxxxxxx>

Please provide a changelog to explain why we need this patch.


---
fs/proc/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index b3647fe..9e8f631 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -427,7 +427,7 @@ struct dentry *proc_lookup_de(struct proc_dir_entry *de, struct inode *dir,
if (!memcmp(dentry->d_name.name, de->name, de->namelen)) {
pde_get(de);
spin_unlock(&proc_subdir_lock);
- error = -EINVAL;
+ error = -ENOMEM;

Why the !memcmp() case is related with ENOMEM ??

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/