Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

[viresh kumar]

On Wed, Sep 26, 2012 at 12:17 PM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> This separate driver makes no sense in case it is built properly without
> CLK framework. Let me check this and leave comments at patch 1/6.

Following is the commit that introduced this change :)

commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1
Author: Viresh Kumar <viresh.kumar@xxxxxx>
Date:   Mon Jul 30 14:39:27 2012 -0700

    clk: add non CONFIG_HAVE_CLK routines

    Many drivers are shared between architectures that may or may not have
    HAVE_CLK selected for them.  To remove compilation errors for them we
    enclose clk_*() calls in these drivers within #ifdef CONFIG_HAVE_CLK,
    #endif.

    This patch removes the need of these CONFIG_HAVE_CLK statements, by
    introducing dummy routines when HAVE_CLK is not selected by platforms.
    So, definition of these routines will always be available.  These calls
    will return error for platforms that don't select HAVE_CLK.

    Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxx>
    Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
    Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    Cc: Jeff Garzik <jgarzik@xxxxxxxxxx>
    Cc: Andrew Lunn <andrew@xxxxxxx>
    Cc: Bhupesh Sharma <bhupesh.sharma@xxxxxx>
    Cc: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
    Cc: Russell King <rmk@xxxxxxxxxxxxxxxx>
    Cc: Mike Turquette <mturquette@xxxxxxxxxx>
    Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
    Cc: viresh kumar <viresh.linux@xxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/