RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irqaffinity mask
From: Liu, Chuansheng
Date: Wed Sep 26 2012 - 02:52:16 EST
> > + } else if (cpumask_test_cpu(cpu, data->affinity))
> > + cpumask_clear_cpu(cpu, data->affinity);
> >
>
> You meant to use 'affinity' (instead of data->affinity) in the above 2 statements
> right? Note that we do chip->irq_set_affinity(data, affinity, true); further down.
>
Yes, I have noticed it, used data->affinity here is just for avoiding compile warning.
in fact affinity == data->affinity, but affinity pointer is const type,
And cpumask_clear_cpu needs non-const type,so here I am using data->affinity,
instead of changing code "const struct cpumask *affinity;"
¢éì®&Þ~º&¶¬+-±éÝ¥w®Ë±Êâmébìdz¹Þ)í
æèw*jg¬±¨¶Ýj/êäz¹Þà2Þ¨èÚ&¢)ß«a¶Úþø®G«éh®æj:+v¨wèÙ>W±êÞiÛaxPjØm¶ÿÃ-»+ùd_