Re: [PATCH] ext3: fix return values on parse_options() failure

[Eric W. Biederman]

LukÃÅ Czerner <lczerner@xxxxxxxxxx> writes:

> On Tue, 9 Oct 2012, Zhao Hongjiang wrote:
>
>> Date: Tue, 09 Oct 2012 13:48:47 +0800
>> From: Zhao Hongjiang <zhaohongjiang37@xxxxxxxxx>
>> To: jack@xxxxxxx
>> Cc: akpm@xxxxxxxxxxxxxxxxxxxx, adilger.kernel@xxxxxxxxx,
>>     linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
>>     Eric W. Biederman <ebiederm@xxxxxxxxxxxx>, serge.hallyn@xxxxxxxxxxxxx,
>>     containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
>> Subject: [PATCH] ext3: fix return values on parse_options() failure
>> 
>> From: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
>> 
>> parse_options() in ext3 should return 0 when parse the mount options fails.
>> 
>
> Ah, it really is a joy to read the parse_options() :). But this fix
> makes sense, thanks for catching it.
>
> Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Ugh.  I goofed that up.  How annoying that ext4 is different than ext3
and ext2 in this regard.

Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/