Re: [PATCH] ext3: fix return values on parse_options() failure

[Jan Kara]

On Tue 09-10-12 08:19:42, LukÃÅ Czerner wrote:
> On Tue, 9 Oct 2012, Zhao Hongjiang wrote:
> 
> > Date: Tue, 09 Oct 2012 13:48:47 +0800
> > From: Zhao Hongjiang <zhaohongjiang37@xxxxxxxxx>
> > To: jack@xxxxxxx
> > Cc: akpm@xxxxxxxxxxxxxxxxxxxx, adilger.kernel@xxxxxxxxx,
> >     linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> >     Eric W. Biederman <ebiederm@xxxxxxxxxxxx>, serge.hallyn@xxxxxxxxxxxxx,
> >     containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
> > Subject: [PATCH] ext3: fix return values on parse_options() failure
> > 
> > From: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
> > 
> > parse_options() in ext3 should return 0 when parse the mount options fails.
> > 
> 
> Ah, it really is a joy to read the parse_options() :). But this fix
> makes sense, thanks for catching it.
> 
> Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx>
  Thanks, added to my tree.

									Honza
> 
> -Lukas
> 
> > Signed-off-by: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
> > ---
> >  fs/ext3/super.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> > index 17ae5c8..ebf8312 100644
> > --- a/fs/ext3/super.c
> > +++ b/fs/ext3/super.c
> > @@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
> >  			uid = make_kuid(current_user_ns(), option);
> >  			if (!uid_valid(uid)) {
> >  				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
> > -				return -1;
> > +				return 0;
> > 
> >  			}
> >  			sbi->s_resuid = uid;
> > @@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
> >  			gid = make_kgid(current_user_ns(), option);
> >  			if (!gid_valid(gid)) {
> >  				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
> > -				return -1;
> > +				return 0;
> >  			}
> >  			sbi->s_resgid = gid;
> >  			break;
> > -- 1.7.1
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/