Re: [RFC PATCH 3/3] Convert mce_disabled

From: Borislav Petkov
Date: Wed Oct 10 2012 - 11:53:57 EST


On Wed, Oct 10, 2012 at 03:46:39PM +0000, Luck, Tony wrote:
> struct mca_config {
> - u64 dont_log_ce : 1,
> -#define MCA_CFG_DONT_LOG_CE 0
> - __resv1 : 63;
> + u64 dont_log_ce : 1,
> +#define MCA_CFG_DONT_LOG_CE 0
> + mca_disabled : 1,
> +#define MCA_CFG_MCA_DISABLED 1
> + __resv1 : 62;
> };
>
> If we do head in this direction - I don't think it is useful to change just one bit
> on each commit. We should batch in larger groups.

Sure, this is just sanity-checking-the-approach patchset, trying to make
the intent as understandable as possible. The real thing should do a
couple of conversions in one patch, of course.

Thanks.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/