Re: [RFC PATCH 3/3] Convert mce_disabled

[Naveen N. Rao]

On 10/10/2012 07:50 PM, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@xxxxxxx>
>
> Not-Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
> ---
>   arch/x86/include/asm/mce.h       |  9 +++++----
>   arch/x86/kernel/cpu/mcheck/mce.c | 12 +++++-------
>   arch/x86/lguest/boot.c           |  2 +-
>   3 files changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
> index 18a66ac35fc5..e8ed5a3a0512 100644
> --- a/arch/x86/include/asm/mce.h
> +++ b/arch/x86/include/asm/mce.h
> @@ -126,7 +126,6 @@ extern void mce_unregister_decode_chain(struct notifier_block *nb);
>   #include <linux/init.h>
>   #include <linux/atomic.h>
>
> -extern int mce_disabled;
>   extern int mce_p5_enabled;
>
>   #ifdef CONFIG_X86_MCE
> @@ -208,9 +207,11 @@ extern void register_mce_write_callback(ssize_t (*)(struct file *filp,
>   				    size_t usize, loff_t *off));
>
>   struct mca_config {
> -	u64 dont_log_ce	: 1,
> -#define MCA_CFG_DONT_LOG_CE	0
> -	    __resv1	: 63;
> +	u64	dont_log_ce	: 1,
> +#define MCA_CFG_DONT_LOG_CE	  0
> +		mca_disabled	: 1,
> +#define MCA_CFG_MCA_DISABLED	  1
> +	    __resv1	: 62;
>   };

Hi Boris,
Thanks for getting to this before I could!

I had a look but I still feel boolean is a better way to go. With bool, 
we can get rid of the #defines above and more importantly, the aux field 
in dev_ext_attribute since that is used in other places too. Further, I 
suspect we'll still end up using the same or less memory since we don't 
have that many boolean members within the MCA code.

Regards,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/