Re: Is not locking task_lock in cgroup_fork() safe?
From: Tejun Heo
Date: Thu Oct 18 2012 - 20:58:03 EST
On Thu, Oct 18, 2012 at 05:38:35PM -0700, Tejun Heo wrote:
> Even if there isn't an actual race, the comment is dead wrong. I'm
> reverting the following three patches. Let's try again later.
> 7e381b0eb1 ("cgroup: Drop task_lock(parent) on cgroup_fork()")
> 7e3aa30ac8 ("cgroup: Remove task_lock() from cgroup_post_fork()")
So, after some more looking, I think the following is correct and
doesn't need to be reverted. It's depending on threadgroup locking
from migration path to synchronize against exit path which is always
> c84cdf75cc ("cgroup: Remove unnecessary task_lock before fetching css_set on migration")
Frederic, were you trying to say that the above commit is correct?
Li, do you agree?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/