Re: [PATCH] memory: of_memory.c: remove unnecessary initialization

From: Santosh Shilimkar
Date: Tue Dec 04 2012 - 09:45:57 EST


On Tuesday 04 December 2012 07:25 PM, Grant Likely wrote:
On Tue, Dec 4, 2012 at 11:44 AM, Santosh Shilimkar
<santosh.shilimkar@xxxxxx> wrote:
On Tuesday 04 December 2012 04:56 PM, Cong Ding wrote:

the initialization of variable ret is unnecessary, we can remove it while
save
one time "or" operation.

Signed-off-by: Cong Ding <dinggnu@xxxxxxxxx>
---

Looks ok.
Acked-by: Santosh Shilimkar<santosh.shilimkar@xxxxxx>


Thanks for the patch, but I don't think it matters enough to apply it.
The existing code isn't wrong.

The patch was removing an additional operation and hence i didn't
contest it. I agree with your comment though.

Regards
Santosh


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/