RE: [PATCH 1/2] regulator: lp8788-buck: Remove val array inlp8788_init_dvs
From: Kim, Milo
Date: Sun Dec 09 2012 - 21:27:57 EST
> All elements of val array are zero.
> Simply set data argument to be 0 in lp8788_update_bits call and remove
> the val
> array.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
Axel, sorry I disagree with this patch because DVS_PIN is meaningful.
In this case, explicit bit description is more important than code simplicity.
So I would keep it.
Thanks,
Milo
N§²æìr¸yúèØb²X¬¶ÇvØ^)Þ{.nÇ+·¥{±êçzX§¶¡Ü}©²ÆzÚ&j:+v¨¾«êçzZ+Ê+zf£¢·h§~Ûiÿûàz¹®w¥¢¸?¨èÚ&¢)ßfù^jÇy§m
á@A«a¶Úÿ0¶ìh®åi