RE: [PATCH 1/2] regulator: lp8788-buck: Remove val array inlp8788_init_dvs

From: Kim, Milo
Date: Sun Dec 09 2012 - 22:22:50 EST


> Actually, what you want is to clear mask[id] bits.
> Setting 0 for the data argument here is clear.

I would say it's not clearing bit but the DVS control configuration.
If the bit is 0, external pin is used for the DVS.
If it is 1, then DVS is controlled by other register settings.
Therefore, it's a kind of default configuration rather than clearing bits.

> But if you prefer to keep it as is, it's ok.
Thanks for your understanding.

Best Regards,
Milo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/