Re: [RFC PATCH 2/3] regulator: max77686: Add support for variousoperating modes

From: Mark Brown
Date: Mon Dec 10 2012 - 01:46:46 EST


On Mon, Dec 10, 2012 at 11:56:23AM +0530, Abhilash Kesavan wrote:

> + if (of_property_read_u32(rdata[i].of_node, "max77686-opmode",
> + &rdata[i].opmode)) {
> + dev_warn(iodev->dev, "no op_mode property property at %s\n",
> + rmatch.name);
> + rdata[i].opmode = regulators[i].enable_mask;
> + }

Binding documenation is mandatory for any new OF properties, please add
this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/