Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6

[Cyrill Gorcunov]

On Mon, Dec 10, 2012 at 03:21:53AM +0100, Jan Engelhardt wrote:
> 
> On Saturday 2012-11-17 00:56, Andrew Morton wrote:
> >>  | pos:	0
> >>  | flags:	02000000
> >>  | inotify wd:        3 ino:             9e7e
> >>  | inotify wd:        2 ino:             a111
> >>  | inotify wd:        1 ino:            6b149[...]
> >
> >This is a lousy output format.  It's sort-of like a sensible set of
> >name-value tuples: "name:value name:value name:value" but
> >
> >c) inotify-wd is secretly printed in decimal while everything else
> >   is in hex.

Hi Jan, not secretly, actually, the patch for documentation in -mm tree,
where the format is described.

> >
> >What happens if we do something like the below (which will require a
> >changelog update)?

It's already there :) Andrew pointed to same nit and we've updated
the format. The final one, which sits in -mm is

	ret = seq_printf(m, "fhandle-bytes:%x fhandle-type:%x f_handle:",
			 f.handle.handle_bytes, f.handle.handle_type);

> >
> >@@ -59,7 +59,7 @@ static int show_mark_fhandle(struct seq_
> > 	f.handle.handle_type = ret;
> > 	f.handle.handle_bytes = size * sizeof(u32);
> > 
> >-	ret = seq_printf(m, "fhandle-bytes: %8x fhandle-type: %8x f_handle: ",
> >+	ret = seq_printf(m, "fhandle-bytes:%x fhandle-type:%x f_handle:",
> > 			 f.handle.handle_bytes, f.handle.handle_type);
> 
> Why don't we actually make sure to print a 0x prefix when it's hex
> and 0 on octal? Then it should be clear what base these lines are in.
> (That would also be a good idea for the rest of procfs files, but I
> reckon they cannot be easily changed.)

Sounds good for me. If Andrew won't mind I'll update.

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/