Re: [GIT PULL] perf changes for v3.8

[Ingo Molnar]

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> > I could write the patch to completely invert the 
> > exclude_guest logic -- make it include_guest. That breaks 
> > all existing perf binaries as well - just a different syntax 
> > that gets broken. That regression is acceptable?
> 
> It's not a regression since THAT CODE NEVER WORKED, for 
> chissake! The case of people actually profiling into virtual 
> machines crashes the running VMs, as you say. There's no way 
> in hell we can call it a regression to say "you now have to 
> use a flag if you profile a load with virtualization", since 
> there wasn't any working case to begin with.

Correct.

::include_guest looks like the more logical flag direction to
use in any case.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/