Re: [PATCH 0/5] [v3] fix illegal use of __pa() in KVM code

From: Dave Hansen
Date: Mon Feb 25 2013 - 09:58:09 EST

On 02/24/2013 01:28 PM, Peter Hurley wrote:
> Now that the alloc_remap() has been/is being removed, is most/all of
> this being reverted?

I _believe_ alloc_remap() is the only case where we actually remapped
low memory. However, there is still other code that does __pa()
translations for percpu areas: per_cpu_ptr_to_phys(). I _think_ it's
still theoretically possible to get some percpu data in the vmalloc() area.

> So in short, my questions are:
> 1) is the slow_virt_to_phys() necessary anymore?

kvm_vcpu_arch has a

struct pvclock_vcpu_time_info hv_clock;

and I believe I mistook the two 'hv_clock's for each other. However,
this doesn't hurt anything, and the performance difference is probably
horribly tiny.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at