Re: [PATCH] idr: Don't WARN in idr_find

From: Peter Hurley
Date: Mon Feb 25 2013 - 20:46:24 EST

On Mon, 2013-02-25 at 17:40 -0800, Tejun Heo wrote:
> On Mon, Feb 25, 2013 at 08:37:12PM -0500, Peter Hurley wrote:
> > Since idr is used for syscall apis (to associate 'handles' with
> > internal structures), don't WARN with invalid input.
> >
> > For example, POSIX timers are identified by timer_t id. These
> > ids are idr values. If userspace passes a representable timer_t id
> > value (eg, id < 0) but which was not previous allocated (since the
> > current idr api does not return negative idr values), then the
> > syscall properly returns an error; a WARN is unnecessary and
> > undesirable.
> WARN_ON() on negative was intentional. Because the previous
> implmentation silently dropped the msb, we at least wanna know who has
> been passing in negative indices. Patch for the lock_timer is already
> in -mm.

Thanks. Can you share the patch title? It's not in next-20130225.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at