Re: [PATCH 2/2 V5] iommu/amd: Add logic to decode AMD IOMMU event flag

From: Shuah Khan
Date: Wed Apr 10 2013 - 12:29:16 EST


On Wed, Apr 10, 2013 at 10:27 AM, Suravee Suthikulanit
<suravee.suthikulpanit@xxxxxxx> wrote:
> On 4/10/2013 11:21 AM, Shuah Khan wrote:
>>
>> Good feature. Do you also plan to add decode logic for these flags.
>> For example, RZ is only meaningful when PR=1, RW is only meaningful
>> when
>> PR=1, TR=0, and I=0, and so on? This additional logic will be useful.
>>
>> Reviewed-by: Shuah Khan<shuahkhan@xxxxxxxxx>
>>
>> -- Shuah
>
> Additional filtering logic can also be added in the future. This will also
> be important if we are planning on handling IOMMU errors.
>

Correct. Additional logic isn't necessary in this patch.

-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/